Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on close promise to Luigi Client openAsModal #3672

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Add on close promise to Luigi Client openAsModal #3672

merged 5 commits into from
Mar 11, 2024

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Mar 7, 2024

No description provided.

@JohannesDoberer JohannesDoberer marked this pull request as ready for review March 8, 2024 14:37
@JohannesDoberer JohannesDoberer added enhancement New feature or request documentation documentation tasks labels Mar 8, 2024
@ndricimrr ndricimrr changed the title modal close promise Add on close promise to Luigi Client openAsModal Mar 11, 2024
@ndricimrr ndricimrr merged commit 729316a into main Mar 11, 2024
12 checks passed
@ndricimrr ndricimrr deleted the modal-close-promise branch March 11, 2024 12:34
@ndricimrr ndricimrr mentioned this pull request Mar 11, 2024
Closed
@JohannesDoberer JohannesDoberer mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

Assignees
No one assigned
Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hardl @JohannesDoberer @ndricimrr