Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading indicator not going away when fast clicking multiple times to a nav node #3679

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Mar 13, 2024

clear timeout before setting it

@ndricimrr ndricimrr added the ora ora related issues label Mar 14, 2024
@ndricimrr ndricimrr self-assigned this Mar 14, 2024
@ndricimrr ndricimrr changed the title fix loading indicator not going away when fast clicking multiple times to a nav node Fix loading indicator not going away when fast clicking multiple times to a nav node Mar 20, 2024
@ndricimrr ndricimrr added the bug Something isn't working label Mar 20, 2024
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to reproduce and tested. Works as expected

@hardl hardl merged commit 62c27d6 into main Mar 20, 2024
11 checks passed
@hardl hardl deleted the fix-loading-indicator branch March 20, 2024 13:06
@JohannesDoberer JohannesDoberer mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ora ora related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants