Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context via config changed #3693

Merged
merged 15 commits into from
May 3, 2024

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented Apr 10, 2024

Fixes #3685

@JohannesDoberer JohannesDoberer marked this pull request as ready for review April 17, 2024 14:51
@ndricimrr ndricimrr self-assigned this Apr 23, 2024
@ndricimrr ndricimrr added documentation documentation tasks enhancement New feature or request labels Apr 29, 2024
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well. Just two small comments regarding documentation

* Updates the context values for visible iframes and LUI web components.
* Note: the updated context values are not persisted. The developers have to do it on their own.
* @param {Object} ctx - The context to be updated.
* @memberof Configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @memberof Configuration
* @memberof Configuration
* @example
* Luigi.updateContextValues({someData: 'myContext'})

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also run npm run docu to regenerate Docu stuff

@JohannesDoberer JohannesDoberer merged commit b1162e5 into main May 3, 2024
11 checks passed
@JohannesDoberer JohannesDoberer deleted the update-context-via-configChanged branch May 3, 2024 09:59
@JohannesDoberer JohannesDoberer mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new scope "navigation.context" to Luigi.configChanged()
2 participants