Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix top nav children not rendered #3727

Merged
merged 26 commits into from
Jun 4, 2024
Merged

Fix top nav children not rendered #3727

merged 26 commits into from
Jun 4, 2024

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented May 14, 2024 •
edited by ndricimrr
Loading

Fixes #3725

@JohannesDoberer JohannesDoberer added the bug Something isn't working label May 16, 2024
@JohannesDoberer JohannesDoberer marked this pull request as ready for review May 16, 2024 08:14
@ndricimrr ndricimrr self-assigned this May 16, 2024
@JohannesDoberer JohannesDoberer added the WIP Work in progress label May 21, 2024
@JohannesDoberer JohannesDoberer removed the WIP Work in progress label May 21, 2024
ndricimrr
ndricimrr approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. I would create a follow up to have a test for this scenario written.

@JohannesDoberer
Copy link
Contributor Author

@ndricimrr I'll add a test scenario to this pr.

@JohannesDoberer JohannesDoberer added the WIP Work in progress label May 24, 2024
@JohannesDoberer JohannesDoberer removed the WIP Work in progress label May 24, 2024
walmazacn
walmazacn approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

ndricimrr
ndricimrr approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

ndricimrr
ndricimrr approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested again and works

@JohannesDoberer JohannesDoberer merged commit ac64b47 into main Jun 4, 2024
11 checks passed
@JohannesDoberer JohannesDoberer deleted the fix-top-nav-children-not-rendered branch June 4, 2024 10:06
This was referenced Jul 4, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@walmazacn walmazacn walmazacn approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa

Assignees

@ndricimrr ndricimrr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No navigation nodes rendered, if children are empty of one node
3 participants
@JohannesDoberer @ndricimrr @walmazacn