Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get current route #3780

Merged
merged 13 commits into from
Jun 25, 2024
Merged

Get current route #3780

merged 13 commits into from
Jun 25, 2024

Conversation

JohannesDoberer
Copy link
Contributor

added App.svelte as internal variable to Luigi

@JohannesDoberer JohannesDoberer marked this pull request as ready for review June 11, 2024 07:06
@ndricimrr ndricimrr self-assigned this Jun 11, 2024
ndricimrr
ndricimrr reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be added so far for Core-Api , Core-WC-clientAPI, but not Container WC-based ClientAPI here. Do we plan to add that there too ?

@JohannesDoberer JohannesDoberer added the WIP Work in progress label Jun 14, 2024
@JohannesDoberer JohannesDoberer removed the WIP Work in progress label Jun 18, 2024
ndricimrr
ndricimrr approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JohannesDoberer JohannesDoberer merged commit 5f4e776 into main Jun 25, 2024
11 checks passed
@JohannesDoberer JohannesDoberer deleted the get-current-route branch June 25, 2024 11:57
@JohannesDoberer JohannesDoberer added enhancement New feature or request container ora ora related issues labels Jun 25, 2024
This was referenced Jul 4, 2024
Merged
Closed
@JohannesDoberer JohannesDoberer mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@walmazacn walmazacn Awaiting requested review from walmazacn walmazacn is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa

Assignees

@ndricimrr ndricimrr

Labels
container enhancement New feature or request ora ora related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesDoberer @ndricimrr