Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong order of productswitcher item #4058

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Wrong order of productswitcher item #4058

merged 4 commits into from
Dec 13, 2024

Conversation

JohannesDoberer
Copy link
Contributor

Elements inside product switcher item have wrong order when addNavHrefs:true in navigation settings + space was not correct due to missing fd class

@JohannesDoberer JohannesDoberer added the bug Something isn't working label Dec 11, 2024
@walmazacn walmazacn self-assigned this Dec 11, 2024
walmazacn
walmazacn approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohannesDoberer JohannesDoberer merged commit 5b395a6 into main Dec 13, 2024
12 checks passed
@JohannesDoberer JohannesDoberer deleted the productswitch-css-bug branch December 13, 2024 10:22
@JohannesDoberer JohannesDoberer added the ora ora related issues label Dec 16, 2024
@JohannesDoberer JohannesDoberer mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmazacn walmazacn walmazacn approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@walmazacn walmazacn

Labels
bug Something isn't working ora ora related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesDoberer @walmazacn