Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Wrong backgroundColor for profile initials #4148

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented Feb 18, 2025

Currently with the following settings (described below) the Initials has no backgroundColor:
Bildschirmfoto 2025-02-18 um 12 12 28

Can be reproduced by the following steps:

  1. index.html
    -> replace <link rel='stylesheet' href='/public/luigi.css'> with <link rel='stylesheet' href='/public/luigi_horizon.css'>
  2. Luigi config:
settings: {
  ....
   responsiveNavigation: 'Fiori3',
   profileType: 'Fiori3',
   experimental: {
      profileMenuFiori3: true
   }
},
navigation: {
  ...nodes,
  profile: {
          logout: {
            label: 'Sign Out',
            icon: "sys-cancel"
          },
          staticUserInfoFn: () => {
            return new Promise(resolve => {
              resolve({
                name: 'Static User',
                initials: 'LU',
                email: 'other.luigi.user@example.com',
                description: 'Luigi Developer'
              });
            });
          }
        }
}

Expected:
Bildschirmfoto 2025-02-18 um 12 15 27

@JohannesDoberer JohannesDoberer added the bug Something isn't working label Feb 18, 2025
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohannesDoberer JohannesDoberer merged commit b266459 into main Feb 18, 2025
11 checks passed
@JohannesDoberer JohannesDoberer deleted the fix-avatar-backgroundcolor branch February 18, 2025 15:08
This was referenced Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants