Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leftnav-btp: fix observer issue #4194

Merged
merged 4 commits into from
Mar 19, 2025
Merged

leftnav-btp: fix observer issue #4194

merged 4 commits into from
Mar 19, 2025

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Mar 14, 2025

No description provided.

@hardl hardl marked this pull request as ready for review March 17, 2025 08:38
walmazacn
walmazacn approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with 'btpToolLayout' enabled and everything works as expected

@hardl hardl merged commit 0923cef into main Mar 19, 2025
11 checks passed
@hardl hardl deleted the btplayout-leftnav-resize branch March 19, 2025 12:53
@walmazacn walmazacn linked an issue Mar 19, 2025 that may be closed by this pull request
btpLayout: collapsed left nav overflow broken #4187
Closed
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Mar 21, 2025
@JohannesDoberer JohannesDoberer mentioned this pull request Mar 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmazacn walmazacn walmazacn approved these changes

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@walmazacn walmazacn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

btpLayout: collapsed left nav overflow broken
3 participants
@hardl @walmazacn @JohannesDoberer