Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fd update #4206

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
ef935d0
Bump fundamental styles to 0.39.0-rc.48
Jan 22, 2025
add100e
Bump fundamental styles to 0.39.0-rc.48
Jan 22, 2025
c323d46
Merge branch 'main' into 4119-bump-fundamental-styles
walmazacn Jan 30, 2025
c05aba9
Merge branch 'main' into 4119-bump-fundamental-styles
amilewskaa Feb 17, 2025
ae61a8e
Update to 0.39.0-rc.64
Feb 17, 2025
88673e6
Merge branch '4119-bump-fundamental-styles' of https://github.com/SAP…
Feb 17, 2025
d305a66
Merge branch 'main' into 4119-bump-fundamental-styles
amilewskaa Feb 17, 2025
a189b82
Fix styles for GlobalSearch
Feb 20, 2025
849db99
Merge branch '4119-bump-fundamental-styles' of https://github.com/SAP…
Feb 20, 2025
aac0fd9
Reset min-width for global search
Feb 24, 2025
fb812db
Reset min-width for GlobalSearch
Feb 24, 2025
8df27ae
Refactor styling for GlobalSearchCentered
Feb 24, 2025
ba53b5e
Apply prettier
Feb 24, 2025
44a7232
Merge branch 'main' into 4119-bump-fundamental-styles
amilewskaa Feb 24, 2025
c04f9e1
Remove height 100%
Feb 24, 2025
a34a714
Fix for height
Feb 24, 2025
87ddae5
Apply prettier
Feb 24, 2025
975f0c7
Merge branch 'main' into 4119-bump-fundamental-styles
JohannesDoberer Feb 24, 2025
3b38187
Merge branch 'main' into 4119-bump-fundamental-styles
JohannesDoberer Feb 25, 2025
20f88df
Update search input witdh and icons height on Desktop View
Feb 27, 2025
e67505c
Apply prettier
Feb 27, 2025
e30ef29
Remove caret
Feb 27, 2025
146b779
Merge branch 'main' into 4119-bump-fundamental-styles
amilewskaa Feb 27, 2025
2c63140
Merge branch 'main' into 4119-bump-fundamental-styles
walmazacn Mar 11, 2025
8cd2dc0
Fixes top nav issues
walmazacn Mar 11, 2025
a9fe076
Merge branch 'main' into 4119-bump-fundamental-styles
JohannesDoberer Mar 14, 2025
16564f1
Logo title + ProfileMenuFiori now arrow
JohannesDoberer Mar 19, 2025
08b333b
prettier
JohannesDoberer Mar 19, 2025
a12ecb2
Merge branch 'main' into fd-update
JohannesDoberer Mar 19, 2025
2c5dd1d
prettier
JohannesDoberer Mar 19, 2025
f9d8539
hide none collapsed category when sidenav is collapsed
JohannesDoberer Mar 21, 2025
60096a2
prettier
JohannesDoberer Mar 21, 2025
c60bd2a
drawer fix
JohannesDoberer Mar 21, 2025
e8d4570
prettier
JohannesDoberer Mar 21, 2025
c145ecd
fix usersettings headers
JohannesDoberer Mar 24, 2025
9a39e4a
prettier
JohannesDoberer Mar 24, 2025
02e20a4
side nav workaround
JohannesDoberer Mar 24, 2025
0c0ee08
fix e2e test
JohannesDoberer Mar 24, 2025
8b30875
Merge branch 'main' into fd-update
JohannesDoberer Mar 24, 2025
1cb773a
revert setting
JohannesDoberer Mar 24, 2025
3ba4786
Merge branch 'fd-update' of github.com:SAP/luigi into fd-update
JohannesDoberer Mar 24, 2025
8ad5304
fonts + version 39.1
JohannesDoberer Mar 25, 2025
7ee13fb
Merge branch 'main' into fd-update
JohannesDoberer Mar 25, 2025
0f26cba
import fonts
JohannesDoberer Mar 25, 2025
cca3295
font
JohannesDoberer Mar 25, 2025
8d8b024
fix compact mode
JohannesDoberer Mar 26, 2025
ffb5d32
prettier
JohannesDoberer Mar 26, 2025
e59110d
apply new dom structure for profile button
JohannesDoberer Mar 26, 2025
ca16173
Merge branch 'main' into fd-update
JohannesDoberer Mar 26, 2025
c7abb77
fix tests regarding new dom structure
JohannesDoberer Mar 26, 2025
65c1558
Merge branch 'fd-update' of github.com:SAP/luigi into fd-update
JohannesDoberer Mar 26, 2025
dba00dc
remove only
JohannesDoberer Mar 26, 2025
2399864
Merge branch 'main' into fd-update
JohannesDoberer Mar 27, 2025
b678862
Merge branch 'main' into fd-update
JohannesDoberer Mar 27, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/examples/luigi-example-openui5/webapp/index.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<title>Luigi</title>
Expand Down
20 changes: 10 additions & 10 deletions core/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"chai": "^4.3.6",
"css-tree": "^2.3.1",
"esbuild": "^0.25.1",
"fs-extra": "^11.3.0",
"fundamental-styles": "0.37.0",
"fs-extra":"^11.3.0",
"fundamental-styles": "0.39.1",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
"jsdom": "^25.0.1",
Expand Down
28 changes: 21 additions & 7 deletions core/src/Modal.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

const dispatch = createEventDispatcher();
let nodeObject;
let btpToolLayout;
let pathData;
let nodeParams;
let iframeCreated = false;
Expand Down Expand Up @@ -253,6 +254,9 @@
settings.title = getNodeLabel(nodeObject);
}
}, ['navigation.viewgroupdata']);
btpToolLayout =
LuigiConfig.getConfigValue('settings.btpToolLayout') &&
GenericHelpers.requestExperimentalFeature('btpToolLayout', false);
EventListenerHelpers.addEventListener('message', onMessage);
// only disable accessibility for all cases other than a drawer without backdrop
!(settings.isDrawer && !settings.backdrop)
Expand Down Expand Up @@ -297,13 +301,15 @@
</script>

<div
class={isModal || (isDrawer && settings.backdrop) ? 'fd-dialog fd-dialog--active' : 'drawer-dialog'}
class={isModal || (isDrawer && settings.backdrop)
? 'fd-dialog fd-dialog--active'
: `drawer-dialog ${btpToolLayout ? 'btp-drawer-dialog' : 'drawer-dialog'}`}
style={isModal ? 'z-index:1001' : ''}
>
<div
class="fd-dialog__content {isDrawer
? settings.backdrop
? 'drawer drawer-dialog__content drawer__backdrop'
? `drawer drawer-dialog__content ${btpToolLayout ? 'btp-drawer__backdrop' : 'drawer__backdrop'}`
: 'drawer drawer-dialog__content'
: 'lui-modal-mf lui-modal-index-' + modalIndex}"
data-testid={isModal ? 'modal-mf' : 'drawer-mf'}
Expand Down Expand Up @@ -364,13 +370,9 @@
</div>

<style lang="scss">
:global(.lui-breadcrumb) .drawer-dialog {
top: calc(#{$combinedLayoutGap} + #{$topNavHeight} + var(--luigi__breadcrumb--height));
}

.drawer-dialog {
position: absolute;
top: calc(#{$combinedLayoutGap} + #{$topNavHeight});
top: calc(#{$topNavHeight} + var(--luigi__breadcrumb--height));
bottom: 0;
width: 25%;
z-index: 3;
Expand All @@ -381,6 +383,10 @@
}
}

.drawer-dialog.btp-drawer-dialog {
top: calc(#{$combinedLayoutGap} + #{$topNavHeight} + var(--luigi__breadcrumb--height));
}

.drawer {
bottom: 0;
width: 25vw;
Expand All @@ -397,6 +403,14 @@
top: $topNavHeight;
}

.btp-drawer__backdrop {
top: calc($topNavHeight + $combinedLayoutGap);
}

:global(.lui-breadcrumb) .btp-drawer__backdrop {
top: calc(#{$topNavHeight} + var(--luigi__breadcrumb--height) + $combinedLayoutGap);
}

.iframeModalCtn {
position: absolute;
height: 100%;
Expand Down
12 changes: 11 additions & 1 deletion core/src/UserSettingsDialog.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -352,13 +352,14 @@
<div class="fd-dialog__body lui-usersettings-body">
<div class="lui-usersettings-left-nav">
<div class="fd-side-nav">
<div class="fd-side-nav__group-header">
<div class="fd-side-nav__group-header lui-us-group-header">
<h2 class="fd-title fd-title--h5" id="dialog-title-2">{$getTranslation(dialogHeader)}</h2>
</div>
<div class="fd-side-nav__main-navigation lui-fd-side-nav__main-navigation">
<ul class="fd-list fd-list--byline fd-list--navigation lui-us-list">
{#each Object.entries(userSettingGroups) as [key, userSettingGroup], index}
{#each Object.entries(userSettingGroup) as userSettingsGroupProperty}
<!-- svelte-ignore a11y-no-noninteractive-element-interactions -->
<li
class="fd-list__item fd-list__item--link lui-us-navlist__item"
data-testid="us-navigation-item"
Expand Down Expand Up @@ -570,6 +571,8 @@
left: var(--left-fd-side-nav-width);
max-width: 55rem;
font-size: var(--sapFontHeader3Size, 20px);
padding: 0.6rem 1rem;
border-bottom: 1px solid var(--sapList_GroupHeaderBorderColor, #d9d9d9);
}

/*customization of FD Styles to align with Fiori 3*/
Expand Down Expand Up @@ -599,6 +602,12 @@
background-color: var(--fdAvatar_BackgroundColor, var(--sapAccentColor6, #286eb4));
}

.lui-us-group-header {
padding: 0.6rem 1rem;
border-right: 0.0625rem solid var(--sapPageFooter_BorderColor);
border-bottom: 1px solid var(--sapList_GroupHeaderBorderColor, #d9d9d9);
}

/*Fiori 3 guidlines*/
@media (min-width: 1024px) {
.lui-usersettings-dialog-size {
Expand Down Expand Up @@ -640,6 +649,7 @@

.lui-usersettings-dialog-sub-header {
left: 0;
display: flex;
}

.lui-usersettings-content-header__back-btn {
Expand Down
1 change: 1 addition & 0 deletions core/src/UserSettingsEditor.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@
<div class="fd-form-item">
<div class="fd-popover">
<!-- svelte-ignore a11y-click-events-have-key-events -->
<!-- svelte-ignore a11y-no-static-element-interactions -->
<div
class="fd-popover__control"
aria-expanded="false"
Expand Down
33 changes: 30 additions & 3 deletions core/src/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,43 @@
}

@font-face {
font-family: '72';
src: url('@sap-theming/theming-base-content/content/Base/baseLib/baseTheme/fonts/72-Regular-full.woff2') format('woff2');
font-family: '72black';
src: url('@sap-theming/theming-base-content/content/Base/baseLib/baseTheme/fonts/72-Black-full.woff2') format('woff2');
font-weight: 400;
font-style: normal;
}

@font-face {
font-family: '72black';
src: url('@sap-theming/theming-base-content/content/Base/baseLib/baseTheme/fonts/72-Black-full.woff2') format('woff2');
src: url('@sap-theming/theming-base-content/content/Base/baseLib/baseTheme/fonts/72-Black-full.woff') format('woff');
font-weight: 400;
font-style: normal;
}

@font-face {
font-family: '72-Semibold';
src: url('@sap-theming/theming-base-content/content/Base/baseLib/baseTheme/fonts/72-Semibold.woff2') format('woff2');
font-weight: 400;
font-style: normal;
}

@font-face {
font-family: '72-Semibold';
src: url('@sap-theming/theming-base-content/content/Base/baseLib/baseTheme/fonts/72-Semibold.woff') format('woff');
font-weight: 400;
font-style: normal;
}

@font-face {
font-family: '72-SemiboldDuplex';
src: url('@sap-theming/theming-base-content/content/Base/baseLib/baseTheme/fonts/72-SemiboldDuplex.woff2') format('woff2');
font-weight: 400;
font-style: normal;
}

@font-face {
font-family: '72-SemiboldDuplex';
src: url('@sap-theming/theming-base-content/content/Base/baseLib/baseTheme/fonts/72-SemiboldDuplex.woff') format('woff');
font-weight: 400;
font-style: normal;
}
15 changes: 15 additions & 0 deletions core/src/navigation/GlobalSearch.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
<ul class="fd-menu__list fd-menu__list--top" bind:this={customSearchItemRendererSlotContainer}>
{#each searchResult as result, index}
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<!-- svelte-ignore a11y-no-noninteractive-element-interactions -->
<li
class="fd-menu__item luigi-search-result-item__{index}"
on:click={(event) => globalSearchHelper.onSearchResultItemSelected(result, event)}
Expand All @@ -99,6 +100,7 @@
>
{#if !globalSearchHelper.isCustomSearchResultItemRenderer}
<!-- svelte-ignore a11y-click-events-have-key-events -->
<!-- svelte-ignore a11y-no-static-element-interactions -->
<!-- svelte-ignore a11y-missing-attribute -->
<a class="fd-menu__link" on:click|preventDefault={() => {}}>
<div class="fd-product-switch__text">
Expand Down Expand Up @@ -127,6 +129,7 @@
</div>
<div class="fd-shellbar__action fd-shellbar__action--desktop">
<!-- svelte-ignore a11y-click-events-have-key-events -->
<!-- svelte-ignore a11y-no-static-element-interactions -->
<div on:click|stopPropagation={() => {}}>
<button
class="fd-button fd-button--transparent fd-shellbar__button"
Expand Down Expand Up @@ -184,6 +187,10 @@

//remove arrow from the search popover
@media screen and (max-width: 1024px) {
:global(.lui-shellbar_group--actions .fd-shellbar__input-group.fd-shellbar__search-field) {
margin-bottom: 0;
}

.luigi-search-shell__mobile {
position: relative;
height: calc(2.25rem + 2px);
Expand All @@ -200,9 +207,17 @@
background: var(--sapShellColor);
z-index: 2;
}

.fd-menu {
max-width: 12rem;
}
}
}

@media (max-width: 599px) {
:global(.lui-shellbar_group--actions .fd-shellbar__input-group.fd-shellbar__search-field) {
max-width: 11rem;
min-width: 0;
}
}
</style>
38 changes: 30 additions & 8 deletions core/src/navigation/GlobalSearchCentered.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,12 @@
<!-- svelte-ignore a11y-missing-attribute -->
<a class="fd-menu__link" on:click|preventDefault={() => {}}>
<div class="fd-product-switch__text">
<div class="fd-product-switch__title">{result.label}</div>
<div class="fd-product-switch__subtitle">{result.description}</div>
<div class="fd-product-switch__title">
{result.label}
</div>
<div class="fd-product-switch__subtitle">
{result.description}
</div>
</div>
</a>
{:else}
Expand Down Expand Up @@ -294,13 +298,10 @@
width: calc(100% - 90px);
left: 0;
top: 0;
height: 100%;
z-index: 2;
padding-left: 1rem;
padding-right: 0.25rem;
.fd-shellbar__input-group {
margin-top: 6px;
}
height: 40px;
}

.lui-global-search-cancel-btn.lui-global-search-cancel-btn--active {
Expand All @@ -313,7 +314,8 @@
top: 0;
z-index: 2;
width: 90px;
height: 100%;
height: 40px;

.fd-shellbar__button {
margin-top: 4px;
}
Expand All @@ -338,10 +340,30 @@
:global(.fd-shellbar__group) {
flex-grow: 1;
}

@media (max-width: 599px) {
:global(.fd-shellbar__logo) {
display: none;
}

:global(.fd-input-group.fd-shellbar__input-group.luigi-search-input-ctn.fd-shellbar__search-field) {
min-width: 0;
}
}

:global(.fd-input-group.fd-shellbar__input-group.luigi-search-input-ctn.fd-shellbar__search-field) {
max-width: none;
}

:global(
.fd-input-group__addon.fd-shellbar__search-field-addon.fd-shellbar__search-cancel.fd-input-group__addon--button,
.fd-input-group__addon.fd-shellbar__search-field-addon.fd-shellbar__search-submit.fd-input-group__addon--button
) {
display: inherit;
}

@media (min-width: 600px) {
:global(.fd-shellbar__group.lui-global-search-cancel-btn.lui-global-search-cancel-btn--active) {
display: none;
}
}
</style>
Loading