Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WITH_CXX11 configuration flag (currently for gcc and clang) #203

Closed
wants to merge 1 commit into from

Conversation

vinesworth
Copy link

Hello!

Here's a patch for SociConfig.cmake. Instead of forcing the C++ standard to be 98, it adds a configuration switch. Unless the latter is explicitly turned on, the default mode is 98. Tested with Clang 3.3 and GCC 4.8.1 on Linux manually, since I'm not sure how to unit-test it (and not familiar with Travis, sorry).

(As of MSVC, its current level of C++11 support leaves me doubtful if it would compile at all...)

@jsonn
Copy link
Contributor

jsonn commented Nov 15, 2013

I'd prefer to just drop the -std=* option completely. It can always be requested by adding to CXXFLAGS. The default is ABI compatible with Clang for either standards, not sure if GCC fixed the issues with libstdc++ they had in the past.

@vinesworth
Copy link
Author

Completely agree, that would be better. I just don't have a FreeBSD machine at hand to test it =(

@mloskot
Copy link
Contributor

mloskot commented May 22, 2015

Since #336, we've got SOCI_CXX_C11 (default is OFF).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants