Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

background: mark failed scans as re-schedulable #1671

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

mssola
Copy link
Collaborator

@mssola mssola commented Feb 8, 2018

After a security scanning iteration, some tags might not be in a
:scan_done state. This is possible in situtations like:

  • Clair was unavailable for some time because of a hiccup.
  • There's an actual bug on the security scanning.

In these cases, we will check in the end of the iteration whether all
tags have been marked as scan. If this is not the case, then we will log
a warning and mark the failed tags as :scan_none (so in the next
iteration they can be picked up and hopefully be scanned properly this
time).

See #1649

Signed-off-by: Miquel Sabaté Solà msabate@suse.com

After a security scanning iteration, some tags might not be in a
:scan_done state. This is possible in situtations like:

- Clair was unavailable for some time because of a hiccup.
- There's an actual bug on the security scanning.

In these cases, we will check in the end of the iteration whether all
tags have been marked as scan. If this is not the case, then we will log
a warning and mark the failed tags as :scan_none (so in the next
iteration they can be picked up and hopefully be scanned properly this
time).

See SUSE#1649

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
Copy link
Contributor

@vitoravelino vitoravelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Vad1mo
Copy link
Contributor

Vad1mo commented Feb 8, 2018

Nice

@vitoravelino vitoravelino merged commit 7f54591 into SUSE:master Feb 8, 2018
@mssola mssola deleted the background-init branch February 8, 2018 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants