This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Fixed hostname copied to clipboard on tags #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal hostname was being referring as the hostname to be copied to the clipboard when the user clicked on the labeled tags. This patch fixes that by checking if external hostname is set or not. If set, external hostname will be used instead of internal hostname. This change affects the API directly because the repository entity is now using the #reacheable_hostname method that tried to prioritize the external hostname if set. Signed-off-by: Vítor Avelino <vavelino@suse.com>
vitoravelino
force-pushed
the
fix-clipboard-external-hostname
branch
from
aa930db to
83b4b3a
Compare
mssola
approved these changes
Apr 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal hostname was being referring as the hostname to be copied
to the clipboard when the user clicked on the labeled tags. This patch
fixes that by checking if external hostname is set or not. If set,
external hostname will be used instead of internal hostname.
This change affects the API directly because the repository entity is
now using the #reacheable_hostname method that tried to prioritize the
external hostname if set.
Signed-off-by: Vítor Avelino vavelino@suse.com
Fixes #1719