This repository was archived by the owner on Apr 17, 2023. It is now read-only.
js: replaced typeahead.js w/ vue-multiselect #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mssola Do not merge this yet. vue-multiselect has an issue regarding tabindex that is only in |
vitoravelino
force-pushed
the
replace-typeahead
branch
4 times, most recently
from
f17ce24 to
0a0168e
Compare
|
@vitoravelino what's the status of this ? |
|
Well, the fix I was looking for wasn't released yet. It's on master. I'm not sure if we should use master branch. |
|
I'll rebase anyway. |
|
@vitoravelino Maybe for now you can pick the specific commit. It's not ideal, but before releasing 2.4 maybe they've released another version 🤔 |
Good idea. I'll try it. |
vitoravelino
force-pushed
the
replace-typeahead
branch
9 times, most recently
from
8917da8 to
3de041b
Compare
Typeahead.js is not maintained anymore for a few years and it doesn't work with modern js. After jQuery upgrade, we had to move jQuery out of package.json because of typeahead. In this patch typeahead.js was removed and replaced by vue-multiselect and jQuery is back to package.json. Signed-off-by: Vítor Avelino <vavelino@suse.com>
vitoravelino
force-pushed
the
replace-typeahead
branch
from
3de041b to
ccdbd31
Compare
|
Green and good to go! 🎉 |
mssola
approved these changes
May 28, 2018
|
Could this be related? #1870 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typeahead.js is not maintained anymore for a few years and it doesn't
work with modern js. After jQuery upgrade, we had to move jQuery out of
package.json because of typeahead.
In this patch typeahead.js was removed and replaced by vue-multiselect
and jQuery is back to package.json.
Signed-off-by: Vítor Avelino vavelino@suse.com
Fixes #1621