Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

config: added pagination options #1815

Merged
merged 1 commit into from
May 11, 2018
Merged

Conversation

vitoravelino
Copy link
Contributor

@vitoravelino vitoravelino commented May 9, 2018

So far the pagination and number of shown pages before and after current
page were hard coded and not configurable.

With this the user can now choose from a configuration perspective how
he wants to show their tables.

Signed-off-by: Vítor Avelino vavelino@suse.com

Fixes #1375

@vitoravelino vitoravelino requested a review from mssola May 9, 2018 15:37
mssola
mssola previously approved these changes May 10, 2018
Copy link
Collaborator

@mssola mssola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo 😉 Thanks!

@@ -340,3 +340,12 @@ background:
# empty. This is the default value since it's deemed to be the most
# common use-case.
strategy: initial

# Pagination confgiuration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"confgiuration" -> "configuration"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

So far the pagination and number of shown pages before and after current
page were hard coded and not configurable.

With this the user can now choose from a configuration perspective how
he wants to show their tables.

Signed-off-by: Vítor Avelino <vavelino@suse.com>
@mssola mssola merged commit 430c3ec into SUSE:master May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants