This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Ldap improvements #1821
Merged
Ldap improvements #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I planned to do more stuff (refactoring some parts), but I thought I'd over-complicate the PR 😅 |
|
There's a single test failing. Fix it and it should be good to merge. It's probably related to the way you are fetching the values from the config since you've changed it in a lot of places. |
With this option you can configure the amount of seconds for a connection timeout with your LDAP server. Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
Instead you should use `ldap.encryption.method`. Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
|
@vitoravelino fixed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two commits that:
methodoption.