This repository was archived by the owner on Apr 17, 2023. It is now read-only.
ui: added visibility to namespace edit form #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visibility change was only possible via namespaces table showed in the namepace#index page. User can now change the visibility while editing a namespace. A <visibility-chooser> component was created to abstract most of the visibilities options. <namespace-visibility> evolved to be a wrapper of the previous component that can be used in standalone to change a namespace remotely. Signed-off-by: Vítor Avelino <vavelino@suse.com>
|
I need to provide that info in the details panel but I'll do it in another PR. |
mssola
approved these changes
May 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visibility change was only possible via namespaces table showed in
the namepace#index page. User can now change the visibility while
editing a namespace.
A component was created to abstract most of the
visibilities options. evolved to be a wrapper of
the previous component that can be used in standalone to change a
namespace remotely.
Signed-off-by: Vítor Avelino vavelino@suse.com
Fixes #1442