This repository was archived by the owner on Apr 17, 2023. It is now read-only.
spec: added chrome headless as default js runner #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitoravelino
force-pushed
the
chrome-headless
branch
8 times, most recently
from
d074626 to
80c8e0a
Compare
vitoravelino
changed the title
mssola
suggested changes
Jun 29, 2018
Dockerfile
Outdated
| @@ -33,4 +34,11 @@ RUN zypper addrepo https://download.opensuse.org/repositories/devel:languages:go | |||
| libtool m4 make makeinfo && \ | |||
| zypper clean -a | |||
|
|
|||
| # Add Google Chrome repo and install it | |||
| RUN zypper -n ar https://dl.google.com/linux/chrome/rpm/stable/x86_64 Chrome && \ | |||
There was a problem hiding this comment.
Merge with the above RUN block.
| gem "codeclimate-test-reporter", group: :test, require: nil | ||
| gem "capybara-screenshot", "~> 1.0.0" | ||
| gem "chromedriver-helper" | ||
| gem "codeclimate-test-reporter", require: false |
There was a problem hiding this comment.
Why did you remove the test group here ?
There was a problem hiding this comment.
Because it's already inside of the test group.
spec/support/capybara.rb
Outdated
| end | ||
| end | ||
|
|
||
| # HACK: when running tests inside of a container we should use poltergeist |
There was a problem hiding this comment.
Maybe this comment should go on the line where you set JAVASCRIPT_DRIVER.
👍 |
vitoravelino
force-pushed
the
chrome-headless
branch
5 times, most recently
from
d62378f to
6e680c1
Compare
So far the feature tests with js enabled were running through poltergeist driver. As we know, PhantomJS was discontinued and that's bad. PhantomJS was far from perfect and we've had a lot of flaky issues with it. Even knowing that most of those flaky issues were our fault, it's always good to improve our workflow whenever possible. Based on this we are adding chrome headless as our default js runner for our feature tests. Unfortunately we had to keep poltergeist for one scenario that we couldn't make chrome headless work properly. That scenario is when the dev runs the feature tests inside of the container. For bare metal and travis, chrome headless works like a charm. Signed-off-by: Vítor Avelino <vavelino@suse.com>
vitoravelino
force-pushed
the
chrome-headless
branch
from
6e680c1 to
d534723
Compare
mssola
approved these changes
Jun 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the feature tests with js enabled were running through
poltergeist driver. As we know, PhantomJS was discontinued and
that's bad. PhantomJS was far from perfect and we've had a lot
of flaky issues with it.
Even knowing that most of those flaky issues were our fault, it's
always good to improve our workflow whenever possible. Based on this we
are adding chrome headless as our default js runner for our feature
tests.
Unfortunately we had to keep poltergeist for one scenario that we
couldn't make chrome headless work properly. That scenario is when the
dev runs the feature tests inside of the container. For bare metal and
travis, chrome headless works like a charm.
Signed-off-by: Vítor Avelino vavelino@suse.com