This repository was archived by the owner on Feb 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
feature: subscriptions api #85
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
00dff3b
feat: init subscriptions
justinemmanuelmercado d273391
fix: update api ver
justinemmanuelmercado e14ba55
test: adds Polly recordings
c46da9d
test: register destination
justinemmanuelmercado a1abaad
test: improve subs test. add test to http for registerDestination case
justinemmanuelmercado 97989cd
feat: register destination. prepare http for fix to clean params
justinemmanuelmercado 3368363
fix: adapt cleanParameters for registerDestination parameters
justinemmanuelmercado 908ecfd
fix: fix parameters registerDestination
justinemmanuelmercado e87ee0e
Merge branch 'master' of https://github.com/ScaleLeap/amazon-mws-api-…
justinemmanuelmercado bc61331
Merge branch 'feature/subscriptions-api' of https://github.com/ScaleL…
justinemmanuelmercado bc50c1b
test: update snapshot
justinemmanuelmercado 78e0aaf
test: deregister destination
justinemmanuelmercado f71d347
feat: deregister destination
justinemmanuelmercado 8e68cd3
test: list registered destinations
justinemmanuelmercado dd5a8d1
test: update deregister destination fixture
justinemmanuelmercado 16c44a0
test: fix formatting errors
justinemmanuelmercado a3d99d0
feat: list registered destinations
justinemmanuelmercado 55e5187
test: send test notification to destination
justinemmanuelmercado 087bf63
feat: send test notification to destination
justinemmanuelmercado 9df2762
test: create subscription test
justinemmanuelmercado bf9379e
test: create subscription
justinemmanuelmercado fee1cfa
test: add more complex test to match createSubscription params
justinemmanuelmercado ccf7ef6
feat: create subscription
justinemmanuelmercado 12d9695
test: get subscription
justinemmanuelmercado 220168b
test: fix get subscription test
justinemmanuelmercado 54d8d20
feat: get subscription
justinemmanuelmercado 45048d8
test: delete_subscription
justinemmanuelmercado a7ad3c5
feat:delete subscription
justinemmanuelmercado 6774259
test: update subscription
justinemmanuelmercado bcf8ad5
feat: update subscription
justinemmanuelmercado cd9346e
fix: lint err
justinemmanuelmercado File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better expressed as
Record<string, ParameterTypes>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that at first, but it threw
Type alias 'ParameterTypes' circularly references itself.
and only used the above as a fix. Any reason why{ [key: string]: ParameterTypes }
won't work?This is where I got the "fix" microsoft/TypeScript#14174. I didn't read through everything though so there may be something I missed in that issue that might've been a better fix