Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Revert "Revert "feature: subscriptions api"" #92

Merged

Conversation

justinemmanuelmercado
Copy link
Contributor

Reverts #88

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020

Codecov Report

Merging #92 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   99.61%   99.65%   +0.04%     
==========================================
  Files          18       19       +1     
  Lines         786      880      +94     
  Branches       54       56       +2     
==========================================
+ Hits          783      877      +94     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
src/http.ts 98.82% <100.00%> (+0.05%) ⬆️
src/index.ts 100.00% <100.00%> (ø)
src/mws.ts 100.00% <100.00%> (ø)
src/sections/subscriptions.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d1b89...e59f763. Read the comment docs.

@justinemmanuelmercado
Copy link
Contributor Author

Hey @roman, I pushed my changes here since it's the most updated one (it includes the history of the revert and re-revert).

@justinemmanuelmercado
Copy link
Contributor Author

#85 (comment) This PR also includes the commit for this.

@justinemmanuelmercado justinemmanuelmercado merged commit 01a71f7 into master Jun 18, 2020
@justinemmanuelmercado justinemmanuelmercado deleted the revert-88-revert-85-feature/subscriptions-api branch June 18, 2020 11:36
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants