SCALRCORE-34472 Variables > Validation conditions with comments can't be evaluated #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recipe
reviewed
Apr 10, 2025
| condition = alltrue([ # Who | ||
| for val in var.values: // would | ||
| /* comment | ||
| like */ |
There was a problem hiding this comment.
@petroprotsakh please add something like this, when the inline comment is inside a block comment on the same line as a terminal sequence for the block comment */
Suggested change
| like */ | |
| // like */ |
There was a problem hiding this comment.
and any other similar combinations
There was a problem hiding this comment.
@recipe Good catch.
Improved the parser and added more tests.
I'll merge the PR and prepare the release if you're happy with it.
recipe
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.