Skip to content

Update lock files and accompanying fixes. #5132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2023
Merged

Update lock files and accompanying fixes. #5132

merged 4 commits into from
Jan 10, 2023

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Jan 9, 2023 •
edited
Loading

🚀 Pull Request

Description

Replaces #5113.

  • Updates lock files with the latest resolvable dependencies.
  • Explicitly sets the y limits of test_2d_coord_bounds_platecarree() to avoid a Cartopy bug.
  • Replaces a use of np.float with float in iris.tests.unit.analysis.maths.
    • Prompted by NumPy v1.24
  • Replaces various uses of np.int.
    • Prompted by NumPy v1.24

Consult Iris pull request check list

@trexfeathers trexfeathers mentioned this pull request Jan 9, 2023
Closed
@bjlittle bjlittle self-requested a review January 10, 2023 09:59
bjlittle
bjlittle approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers (and @rcomer) Awesome work 🏆

Thanks 👍

@bjlittle bjlittle merged commit e883799 into SciTools:main Jan 10, 2023
@trexfeathers
Copy link
Contributor Author

Thanks @bjlittle!

@github-actions github-actions bot mentioned this pull request Jan 11, 2023
Closed
trexfeathers added a commit to trexfeathers/iris that referenced this pull request Feb 21, 2023
@trexfeathers @web-flow
Update lock files and accompanying fixes. (SciTools#5132), and resolv…
580bbc7 
…ing conflicts.

* Updated environment lockfiles

* Use set_ylim for test_2d_coord_bounds_platecarree.

* Don't use np.float for maths tests.

* Remove uses of np.int .

Co-authored-by: Lockfile bot <noreply@github.com>
@trexfeathers trexfeathers deleted the 5113_fixes branch February 24, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlittle bjlittle bjlittle approved these changes

Assignees

@bjlittle bjlittle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trexfeathers @bjlittle @web-flow