Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP proxying. #2804

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

seanparsons
Copy link
Contributor

WHY are these changes introduced?

The node fetch function doesn't currently handle HTTP proxies and as a result if a user has a mandatory proxying requirement in their environment the upgrade check fails.

WHAT is this pull request doing?

In getChangelog, the regular fetch function has been switched out for the implementation provided by @shopify/cli-kit which does handle HTTP proxies correctly.

HOW to test your changes?

Running npx shopify hydrogen dev with this installed should result in the changelog being pulled if not in the monorepo.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

Copy link
Contributor

shopify bot commented Mar 21, 2025

Oxygen deployed a preview of your refactor/use-cli-kit-fetch branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment March 28, 202511:27 AM
Skeleton (skeleton.hydrogen.shop) ❌ Error (Logs) - Inspect deployment March 28, 2025 2:47 PM
custom-cart-method ❌ Error (Logs) - Inspect deployment March 28, 2025 2:47 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment March 28, 202511:27 AM
third-party-queries-caching ❌ Error (Logs) - Inspect deployment March 28, 2025 2:47 PM

Learn more about Hydrogen's GitHub integration.

@seanparsons seanparsons marked this pull request as draft March 28, 2025 15:16
@seanparsons seanparsons changed the title Switch the cli package to using the cli-kit fetch function. Add support for HTTP proxying. Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant