-
Notifications
You must be signed in to change notification settings - Fork 69
Add hide-able enable action for compound #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you get a boolean attribute and use that as a filter to enable the actions which depend on such approval? |
Yes but you can't show/hide based on this, need to add a way to hide the actions and reveal others. |
Hiding would be bad ux because it breaks discoverability. if you hit an action which is disabled, you should get a message on why it is disabled. I think not only tokenscript supported filter, but also a localised message to go with it? |
Atm I am doing it the manual way, but this action should be hidden after it
is enabled.
On Sun, 18 Aug 2019 at 4:48 PM, Weiwu Zhang ***@***.***> wrote:
Hiding would be bad user interface because it breaks discoverability. if
you hit an action which is disabled, you should get a message on why it is
disabled. I think not only tokenscript supported filter, but also a
localised message to go with it?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#222>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD64F4W4QUHMLEDME2CHYFLQFDWDBANCNFSM4IMRMCKA>
.
--
James Sangalli
|
Compound requires that you enable it via approve in the native token. Without this the user cannot use the service. Transactions will successfully execute but silently fail.
Should be able to have an enable action which only shows if the user has not done so, after it is enabled, the other actions should show up.
The text was updated successfully, but these errors were encountered: