Skip to content

Add hide-able enable action for compound #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bitcoinwarrior1 opened this issue Aug 18, 2019 · 4 comments
Open

Add hide-able enable action for compound #222

bitcoinwarrior1 opened this issue Aug 18, 2019 · 4 comments
Assignees

Comments

@bitcoinwarrior1
Copy link
Contributor

Compound requires that you enable it via approve in the native token. Without this the user cannot use the service. Transactions will successfully execute but silently fail.

Should be able to have an enable action which only shows if the user has not done so, after it is enabled, the other actions should show up.

@bitcoinwarrior1 bitcoinwarrior1 changed the title Add hidable enable action for compound Add hide-able enable action for compound Aug 18, 2019
@SmartLayer
Copy link

Can you get a boolean attribute and use that as a filter to enable the actions which depend on such approval?

@bitcoinwarrior1
Copy link
Contributor Author

Yes but you can't show/hide based on this, need to add a way to hide the actions and reveal others.

@SmartLayer
Copy link

SmartLayer commented Aug 18, 2019

Hiding would be bad ux because it breaks discoverability. if you hit an action which is disabled, you should get a message on why it is disabled. I think not only tokenscript supported filter, but also a localised message to go with it?

@bitcoinwarrior1
Copy link
Contributor Author

bitcoinwarrior1 commented Aug 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants