change schema to october

[bitcoinwarrior1]

@colourful-land please resume work on return types from this PR and then we can update everything and merge

[SmartLayer]

This issue intends to solve #225 but it's unfished yet

[SmartLayer]

@James-Sangalli I've done my changes to add bitmask to the ethereum element. Can you check if every example passes the new schema and if so, update every example to refer to the new schema? Thanks.

[bitcoinwarrior1]

@James-Sangalli I've done my changes to add bitmask to the ethereum element. Can you check if every example passes the new schema and if so, update every example to refer to the new schema? Thanks.

@colourful-land schema validation fails on legacy tokenscripts,try it out in the intellij IDE as it will syntax highlight.

Error for compound ZRX token:

$ make cZRX.canonicalized.xml cZRX.canonicalized.xml.INVALID:1: element token: Schemas validity error : Element '{http://tokenscript.org/2019/10/tokenscript}token': No matching global declaration available for the validation root. cZRX.canonicalized.xml.INVALID fails to validate make: [cZRX.canonicalized.xml] Error 3 (ignored)

[bitcoinwarrior1]

@colourful-land might be good to add arrays to this Schema version as well?

[SmartLayer]

@James-Sangalli I've done my changes to add bitmask to the ethereum element. Can you check if every example passes the new schema and if so, update every example to refer to the new schema? Thanks.

@colourful-land schema validation fails on legacy tokenscripts,try it out in the intellij IDE as it will syntax highlight.

Error for compound ZRX token:

$ make cZRX.canonicalized.xml cZRX.canonicalized.xml.INVALID:1: element token: Schemas validity error : Element '{http://tokenscript.org/2019/10/tokenscript}token': No matching global declaration available for the validation root. cZRX.canonicalized.xml.INVALID fails to validate make: [cZRX.canonicalized.xml] Error 3 (ignored)

I think you can work out this one on yourself if you observe how I updated one example. Observe how I made Devcon.xml work:

$ make Devcon.canonicalized.xml
# XML Canonicalization
xmlstarlet c14n Devcon.xml  > Devcon.canonicalized.xml
# XML Validation
xmlstarlet val --xsd ../../schema/tokenscript.xsd Devcon.canonicalized.xml || (mv Devcon.canonicalized.xml Devcon.canonicalized.xml.INVALID; xmllint --noout --schema ../../schema/tokenscript.xsd Devcon.canonicalized.xml.INVALID)
Devcon.canonicalized.xml - valid

[bitcoinwarrior1]

@colourful-land yup, it's working but the IDE doesn't like it mostly likely because the web path doesn't exist yet

[bitcoinwarrior1]

@colourful-land have changed the TS files and removed the JS hack for compound e8 multipliers. Still WIP until we make the tokenscript schema for 2019/10 on the web

[bitcoinwarrior1]

@colourful-land also need to add the bitmask

[bitcoinwarrior1]

@colourful-land also need to add the bitmask

Apologies, see you already have this

[bitcoinwarrior1]

@colourful-land ready to merge

Edit: Let's keep it open until we release the apps with new schema

[bitcoinwarrior1]

@colourful-land iOS completed, just need to do android now

[bitcoinwarrior1]

Android complete but needs review and iOS needs to fix issues with new schema

[bitcoinwarrior1]

@colourful-land #252 is solved in 579a8d6

[bitcoinwarrior1]

iOS problem fixed here: AlphaWallet/alpha-wallet-ios#1495 once merged we are ready to go