Skip to content

switched npm package polyfill for bigint to big-integer, updated Sign… #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

nicktaras
Copy link
Contributor

  • Switched to using this BigInt polyfill library with 0 dependancies and over 1.2 million downloads per week.

https://www.npmjs.com/package/big-integer

  • Simplified the return statement of getTokenInstances() to return the web data to the webster.

…edDevonTicket.jsto work with this polyfill library.
@nicktaras nicktaras requested a review from SmartLayer January 7, 2021 05:19
@nicktaras
Copy link
Contributor Author

This change fixes issue: #410

@AW-STJ
Copy link
Contributor

AW-STJ commented Jan 7, 2021

just realised that the ticket attestations that I used have same ticket IDs. Will test again with different ticket IDs and confirm

@AW-STJ
Copy link
Contributor

AW-STJ commented Jan 7, 2021

Works correctly with attestations with different ticket IDs.

@AW-STJ AW-STJ merged commit c81f55f into main Jan 7, 2021
SmartLayer pushed a commit that referenced this pull request Jun 30, 2023
switched npm package polyfill for bigint to big-integer, updated Sign…
SmartLayer pushed a commit that referenced this pull request Jun 30, 2023
switched npm package polyfill for bigint to big-integer, updated Sign…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants