Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uiopen path change in R2024b causing recursion bug #215 #216

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

mducle
Copy link
Member

@mducle mducle commented Feb 28, 2025

The path to the uiopen function changed in Matlab R2024b so the old code to add drag-and-drop of CIF to SpinW was then causing a bug everytime users try to open a file from the file tree (inside Matlab). This PR fixes it.

To test:

Load SpinW in R2024b. Double click on an .m file in the left panel (Current Folder) and check that the Maximum recursion limit of 500 reached error does not occur.

@mducle mducle added the bug Something isn't working label Feb 28, 2025
@mducle mducle requested a review from lucas-wilkins February 28, 2025 16:27
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 43.27%. Comparing base (ecfd2c9) to head (0181ae6).

Files with missing lines Patch % Lines
external/uiopen.m 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   43.29%   43.27%   -0.02%     
==========================================
  Files         243      243              
  Lines       16383    16389       +6     
==========================================
  Hits         7093     7093              
- Misses       9290     9296       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

    4 files  ±0    124 suites  ±0   6m 6s ⏱️ -9s
  831 tests ±0    813 ✅ ±0  18 💤 ±0  0 ❌ ±0 
2 324 runs  ±0  2 288 ✅ ±0  36 💤 ±0  0 ❌ ±0 

Results for commit 0181ae6. ± Comparison against base commit ecfd2c9.

@mducle mducle merged commit 4f519a1 into master Mar 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants