Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding resfinder version 4.6.0 #1229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

erinyoung
Copy link
Contributor

There's a new version of resfinder!

I'm sure there are bug fixes and new features.

Part of #1170

I copied the files from 4.5.0 and made some changes:

  • updated the version arg for RESFINDER, KMA, the RESFINDER_DB, and the POINTFINDER_DB. DISINFINDER_DB did not appear to have any updates.
  • added --no-cache-dir to the pip install layer.
  • chaned as to AS.

The full diff:

$ diff build-files/resfinder/4.*0/Dockerfile
1c1
< ARG RESFINDER_VER="4.5.0"
---
> ARG RESFINDER_VER="4.6.0"
3c3
< FROM ubuntu:jammy as app
---
> FROM ubuntu:jammy AS app
7c7
< ARG KMA_VER="1.4.14"
---
> ARG KMA_VER="1.4.17"
9c9
< # Database may not be properly versioned, but using a version tag here (2024-03-08)
---
> # Database may not be properly versioned, but using a version tag here (2024-08-06)
11c11
< ARG RESFINDER_DB_COMMIT_HASH="2.3.1"
---
> ARG RESFINDER_DB_COMMIT_HASH="2.4.0"
13c13
< # Database may not be properly versioned, but using a version tag here (2024-03-08)
---
> # Database may not be properly versioned, but using a version tag here (2024-08-08)
15c15
< ARG POINTFINDER_DB_COMMIT_HASH="4.1.0"
---
> ARG POINTFINDER_DB_COMMIT_HASH="4.1.1"
59c59
< RUN pip3 install resfinder==${RESFINDER_VER} && \
---
> RUN pip3 install --no-cache-dir resfinder==${RESFINDER_VER} && \
101c101
< FROM app as test
---
> FROM app AS test

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant