Upgrade Playwright to the latest version #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
force-pushed
the
upgrade-playwright
branch
from
6f4dc64 to
d599e1c
Compare
|
Note that the CI will fail on the Node.js tests, this is not due to the changes in this PR, but due to the fact that Node.js introduced support for |
|
@Stuk could I ask you for a review of this one? |
Stuk
reviewed
Mar 14, 2025
I haven't deleted it, but the diff is quite big because of the change in transitive dependencies, making it look like it was removed. If you click 'load diff' in the GitHub UI it should show you the actual changes. |
|
Ah, my mistake! |
Stuk
approved these changes
Mar 14, 2025
|
Merging this in, even though CI is failing as this is unrelated to the changes of the PR. Either way, we'll fix CI later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Playwright to the latest version, this allows it to install browsers on newer distributions such as Ubuntu 24.04 LTS, which is used on GitHub Actions.