Skip to content

fix: missing extraction of operators in SymbolicUtils convert #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

MilesCranmer
Copy link
Member

Copy link
Contributor

Benchmark Results

master e469bad... master/e469badd493c6e...
eval/ComplexF32/evaluation 7.13 ± 0.58 ms 6.78 ± 0.58 ms 1.05
eval/ComplexF64/evaluation 10.1 ± 0.76 ms 10.3 ± 0.84 ms 0.99
eval/Float32/derivative 10.6 ± 0.78 ms 10.8 ± 0.95 ms 0.98
eval/Float32/derivative_turbo 10.6 ± 0.76 ms 10.8 ± 0.85 ms 0.984
eval/Float32/evaluation 2.61 ± 0.28 ms 2.59 ± 0.28 ms 1.01
eval/Float32/evaluation_bumper 0.559 ± 0.038 ms 0.584 ± 0.043 ms 0.958
eval/Float32/evaluation_turbo 0.515 ± 0.037 ms 0.51 ± 0.043 ms 1.01
eval/Float32/evaluation_turbo_bumper 0.531 ± 0.034 ms 0.582 ± 0.043 ms 0.912
eval/Float64/derivative 14.5 ± 0.8 ms 13.9 ± 0.71 ms 1.04
eval/Float64/derivative_turbo 14.7 ± 0.79 ms 13.7 ± 0.6 ms 1.08
eval/Float64/evaluation 3.12 ± 0.37 ms 3.07 ± 0.32 ms 1.02
eval/Float64/evaluation_bumper 1.15 ± 0.084 ms 1.24 ± 0.051 ms 0.923
eval/Float64/evaluation_turbo 0.955 ± 0.084 ms 0.978 ± 0.083 ms 0.977
eval/Float64/evaluation_turbo_bumper 1.11 ± 0.074 ms 1.23 ± 0.091 ms 0.907
utils/combine_operators/break_sharing 0.0352 ± 0.0018 ms 0.0389 ± 0.003 ms 0.906
utils/convert/break_sharing 25.9 ± 2.4 μs 25.2 ± 2.9 μs 1.03
utils/convert/preserve_sharing 0.0975 ± 0.0036 ms 0.0903 ± 0.0079 ms 1.08
utils/copy/break_sharing 25.5 ± 2.8 μs 26.5 ± 2.6 μs 0.962
utils/copy/preserve_sharing 0.0913 ± 0.0075 ms 0.0966 ± 0.0032 ms 0.945
utils/count_constant_nodes/break_sharing 8.58 ± 0.27 μs 7.68 ± 0.56 μs 1.12
utils/count_constant_nodes/preserve_sharing 0.0834 ± 0.0073 ms 0.0782 ± 0.0058 ms 1.07
utils/count_depth/break_sharing 8.5 ± 0.59 μs 8.95 ± 0.71 μs 0.95
utils/count_nodes/break_sharing 7.39 ± 0.62 μs 7.71 ± 0.44 μs 0.959
utils/count_nodes/preserve_sharing 0.0847 ± 0.0036 ms 0.0793 ± 0.0071 ms 1.07
utils/get_set_constants!/break_sharing 30.6 ± 3.1 μs 0.0332 ± 0.0036 ms 0.923
utils/get_set_constants!/preserve_sharing 0.162 ± 0.014 ms 0.171 ± 0.014 ms 0.951
utils/get_set_constants_parametric 0.0437 ± 0.0035 ms 0.041 ± 0.0036 ms 1.07
utils/has_constants/break_sharing 3.76 ± 0.27 μs 4.38 ± 0.36 μs 0.859
utils/has_operators/break_sharing 1.85 ± 0.14 μs 1.67 ± 0.14 μs 1.1
utils/hash/break_sharing 21.1 ± 1.7 μs 22.7 ± 1.8 μs 0.933
utils/hash/preserve_sharing 0.0901 ± 0.0073 ms 0.0948 ± 0.0077 ms 0.95
utils/index_constant_nodes/break_sharing 24.4 ± 0.96 μs 23.5 ± 2 μs 1.04
utils/index_constant_nodes/preserve_sharing 0.095 ± 0.0084 ms 0.0904 ± 0.0075 ms 1.05
utils/is_constant/break_sharing 4.09 ± 0.31 μs 3.99 ± 0.3 μs 1.03
utils/simplify_tree/break_sharing 0.155 ± 0.011 ms 0.163 ± 0.0054 ms 0.954
utils/simplify_tree/preserve_sharing 0.21 ± 0.017 ms 0.214 ± 0.014 ms 0.981
utils/string_tree/break_sharing 0.424 ± 0.029 ms 0.44 ± 0.025 ms 0.962
utils/string_tree/preserve_sharing 0.522 ± 0.033 ms 0.54 ± 0.036 ms 0.966
time_to_load 0.218 ± 0.001 s 0.215 ± 0.0047 s 1.01

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12476502676

Details

  • 12 of 13 (92.31%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 95.602%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ext/DynamicExpressionsSymbolicUtilsExt.jl 12 13 92.31%
Totals Coverage Status
Change from base Build 12435483943: 0.05%
Covered Lines: 2565
Relevant Lines: 2683

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit 68ae660 into master Dec 24, 2024
14 checks passed
@MilesCranmer MilesCranmer deleted the add-missing-symbolic-export branch December 24, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants