-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure valid custom toolchain name for qoriq-6.2.4 (powerpc-unknown-linux-gnuspe) #6477
Ensure valid custom toolchain name for qoriq-6.2.4 (powerpc-unknown-linux-gnuspe) #6477
Conversation
@th0ma7, this should resolve the build issue with |
I suppose this is an upstream issue. Instead of setting a toolchain version like stable, nightly, ... it was always supported to use a specific version like 1.82.0.
I have no idea if it has anything to do with the launch of "Rust 2024". Rust 1.85.0 was released on 20 Feb 2025 so this issue may pop up in other use cases shortly... |
Currently this issue is not fixed. Building diyspk/ripgrep fails for qoriq-6.2.4:
|
@mreid-tt I have updated the custom rust version to include the |
- add stable- prefix - remarks: 1.82.0 is the final version that can be built with qoriq-6.2.4 toolchain
…t/spksrc into framework-rust-qoriq-fix
I have recreated the custom qoriq toolchain and uploaded to https://github.com/SynoCommunity/spksrc/releases/tag/rust%2Fqoriq Unfortunately version 1.82.0 is the latest version that can be built.
|
Okay, I'll keep an eye on this. The last change I made before your commits allowed However, I did notice a different error in the build for
Should we address this in the same PR, or is it a separate issue that requires a new PR? |
This reverts commit 3e65887.
LGTM: |
Out of curiosity, was it even needed to rebuild the toolchain? Or was it just a naming issue? And thnx for fixing this 🙂 |
The changes I made were primarily related to renaming. @hgy59 added a correctly named version to the repository and referenced it more elegantly, along with a few minor cleanups. However, from my perspective, the main issue was the custom toolchain naming syntax.
You're welcome! Happy to support your work with Python. You should be able to merge this into your branch and achieve a successful build, as I did with |
Just renaming fixed it, but since the rebuilt package was some bytes smaller I replaced the renamed with the rebuilt package. |
Description
This resolves recent build failures in #6454 and #6471 when building
qoriq-6.2.4
packages, which reported an "invalid custom toolchain name" after a recent Rust update. The fix applies a custom toolchain channel prefix aligned with the documented standard for toolchain files.Follow-on from #5879.
Fixes #
Checklist
all-supported
completed successfullyType of change