fix: shiki -> react-syntax-highlighter #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces Code again / customizable prism theme
|
@epoll31 is attempting to deploy a commit to the SyntaxUI Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
what are these useMemo() doing?
|
I used them to avoid performing those string mutations on rerenders. They are pretty simple so I don't think that they are vital, but I thought it would be better with them. Specifically, the code one trims the extra white space and newlines. And, the language one removes "language-" from the language or returns "plaintext" when no language specified |
Ansub
approved these changes
May 3, 2024
Comment on lines
+38
to
+42
| const lang = useMemo( | ||
| () => (rawLang ? rawLang.replace('language-', '') : 'plaintext'), | ||
| [rawLang], | ||
| ) | ||
| const code = useMemo(() => rawCode.trim(), [rawCode]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
using
react-syntax-highlighterin Code now / ComponentPreview references Code again / customizable prism themeRelated Issue
Fixes #135
Proposed Changes
react-syntax-highlighterinstead ofcodeToHtmlinsrc/components/code/Code.tsxCodeinstead ofreact-syntax-highlighterinsrc/components/code/ComponentPreview.tsxto only referencereact-syntax-highlighterin one placereact-syntax-highlighteruses a theme defined insrc/components/code/theme.tssrc/styles/tailwind.cssScreenshots
Checklist
Please check the boxes that apply:
npm run buildand build is successful