Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks - Better error handling and logging #42

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

piotrmacha
Copy link
Contributor

Current hook runner doesn't verify return code of scripts and treats every execution as succesful. When we use hooks to include additional steps in the build pipeline, it's confusing when an important script fails without any indication.

I propose 2 changes:

  1. Log warn if hook exit code is not 0
  2. Log hook standard output and standard error when verbosity is Detailed

Both features are verified by corresponding unit test.

@Szmyk Szmyk merged commit 510c87e into Szmyk:master Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants