Sdk version component #1357
Sdk version component #1357
Conversation
dayhaysoos
requested review from
angiejones,
EbonyLouis and
leordev
as code owners
✅ Deploy Preview for tbd-website-developer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
site/src/components/Dependencies.jsx
Outdated
| const { SDK_VERSIONS } = customFields; | ||
|
|
||
| if (display === 'command') { | ||
| if (language === 'javascript') { |
There was a problem hiding this comment.
should this be a switch statement?
site/src/components/Dependencies.jsx
Outdated
|
|
||
| const { SDK_VERSIONS } = customFields; | ||
|
|
||
| if (display === 'command') { |
There was a problem hiding this comment.
should this be a switch statement?
There was a problem hiding this comment.
alternatively: document other possible values for display
There was a problem hiding this comment.
From the feedback I got from dev rel, might make sense to rename to "install"
site/src/components/Dependencies.jsx
Outdated
| switch (language) { | ||
| case 'javascript': | ||
| Dependency = <PackageJson sdkVersions={SDK_VERSIONS} dependencies={dependencies} />; | ||
| break; |
There was a problem hiding this comment.
I think so far the only language we need this for is javascript, going to follow up with Dev Rel on this
…5/developer.tbd.website into sdk-version-component
There was a problem hiding this comment.
can we rename these components so there's a clear indicator in how they differ? From a glance, I can't tell what Dependencies does vs Dependency. I'd need to read the code each time I want to grab this
There was a problem hiding this comment.
What do you think about the name <TabbedDependencies />?
This PR introduces a new component for surfacing dependencies in documentation. The goal is to be adaptive to the multiple language SDKs we provide while also correctly referring to the correct version. Only step left is adding how to use it in the contributing doc