fix: Add a graph named "voice_assistant_multimodal" in the property.son of default. #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
plutoless
requested changes
Feb 13, 2025
There was a problem hiding this comment.
you should register nova as a llm module in playground moduleConfig.ts
the concept of playground is using the same connections while developers are able to switch modules. if you believe video feature is needed, it should rather be a option feature flag for llm module.
to conclude,
- add nova to llm registry in moduleConfig.ts
- in moduleConfig.ts for llm module add an option
modalities=["image", "text"] - change ChatCfgModuleSelect.tsx so that a connection from rtc to llm will be added when a llm module accepts image input
…"image", "text"] change ChatCfgModuleSelect.tsx so that a connection from rtc to llm will be added when a llm module accepts image input
plutoless
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some developers are confused about debugging the Amazon Nova multimodal model, so we are adding a copy of the demo graph to the default configuration.