feat: temporary modal to edit datetime fields and small refactors #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computerdores
added
Type: Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small refactors to
qt/widgets/preview/field_containers.pyin order to fix warnings.Also adds a temporary modal for DATETIME fields so that they can be edited at all, before proper editing support comes in 9.6.
Note: This PR doesn't conflict with #904 as DATETIME fields were overlooked there. I would suggest merging #904 before this PR and then adding the settings integration for DATETIME fields to this PR (#904 has been sitting for a while now so this way it should get resolved sooner overall).
Tasks Completed