Skip to content

test that Suspense mode calls queryFn only once #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020

Conversation

simoncarpinter
Copy link
Contributor

See #324 -- this adds some test coverage. I'd like to fix the bug too, but haven't yet spotted where it's lurking.

cleanup()
})

it('should not call the queryFn twice when used in Suspense mode', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove the "when used in Suspense mode" bit, woops.

Suggested change
it('should not call the queryFn twice when used in Suspense mode', async () => {
it('should not call the queryFn twice', async () => {

@tannerlinsley tannerlinsley merged commit c83bb19 into TanStack:master May 1, 2020
Copy link

nx-cloud bot commented Apr 7, 2025

View your CI Pipeline Execution ↗ for commit cc09457.

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-18 17:59:11 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants