Skip to content

perf(vue-query): clean up the type definition about query composables #6126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Mini-ghost
Copy link
Contributor

Description

After PR #6043, there is no longer a need to override the UseQueryReturnType type returned by useBaseQuery, so this PR cleans up the type definition, making it appear cleaner and improving type resolution performance.

I cloned the repository mentioned in issue #4556 and tried running it, and nothing broke after this PR.

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
query 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 7:46am

@nx-cloud
Copy link

nx-cloud bot commented Oct 10, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 217f99e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 217f99e:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
packages/vue-query/src/useInfiniteQuery.ts 100.00% <ø> (ø)
packages/vue-query/src/useQuery.ts 100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@Mini-ghost Mini-ghost changed the base branch from main to v4 October 17, 2023 14:29
@DamianOsipiuk DamianOsipiuk merged commit 7e2db91 into TanStack:v4 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants