Skip to content

chore: add typescript-eslint/require-await rule #9029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

chore: add typescript-eslint/require-await rule #9029

wants to merge 20 commits into from
+8 −7

Conversation

minseong0324
Copy link
Contributor

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 15, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bf4a823.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 4m 53s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 44s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-04 19:08:59 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 15, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9029

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9029

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9029

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9029

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9029

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9029

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9029

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9029

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9029

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9029

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9029

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9029

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9029

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9029

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9029

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9029

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9029

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9029

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9029

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9029

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9029

commit: bf4a823

TkDodo
TkDodo reviewed Apr 17, 2025
View reviewed changes
@minseong0324 minseong0324 marked this pull request as draft April 18, 2025 15:44
@minseong0324 minseong0324 force-pushed the chore/ts-async-lint-rules branch 3 times, most recently from a923146 to 390a5cb Compare April 18, 2025 16:16
@minseong0324 minseong0324 force-pushed the chore/ts-async-lint-rules branch from 390a5cb to 9ad919a Compare April 18, 2025 16:25
@minseong0324 minseong0324 marked this pull request as ready for review April 18, 2025 16:26
TkDodo
TkDodo reviewed Apr 19, 2025
View reviewed changes
@TkDodo
Copy link
Collaborator

TkDodo commented May 4, 2025

seems like there are still some violations left (or were added in the meantime). Can you fix them in this PR ?

@minseong0324
Copy link
Contributor Author

seems like there are still some violations left (or were added in the meantime). Can you fix them in this PR ?

Sure, I’ll take care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo left review comments

Assignees
No one assigned
Labels
package: angular-query-experimental package: query-broadcast-client-experimental package: query-core package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minseong0324 @TkDodo