Skip to content

Apa style #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 6, 2024
Merged

Apa style #38

merged 7 commits into from
Dec 6, 2024

Conversation

rlanzafame
Copy link
Member

Note that this should be considered a stable but temporary fix; this should be done with a sphinx extension. See project description Citations and References (view)

@Tom-van-Woudenberg Tom-van-Woudenberg self-requested a review December 5, 2024 10:58
Copy link
Member

@Tom-van-Woudenberg Tom-van-Woudenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built gives error:

/home/runner/work/manual/manual/book/_ext/pybtexapastyle/labels/apa.py:59: SyntaxWarning: is with a literal. Did you mean ==?
  if len(persons) is 1:
/home/runner/work/manual/manual/book/_ext/pybtexapastyle/labels/apa.py:61: SyntaxWarning: is with a literal. Did you mean ==?
  elif len(persons) is 2:

@rlanzafame
Copy link
Member Author

psssssh it's a warning, not an error!

@rlanzafame
Copy link
Member Author

@Tom-van-Woudenberg i think its foine now

@rlanzafame rlanzafame removed the request for review from Tom-van-Woudenberg December 6, 2024 12:31
@rlanzafame rlanzafame merged commit 9e4d6a2 into release Dec 6, 2024
6 checks passed
@rlanzafame rlanzafame deleted the apa-style branch December 6, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants