Fix shift_indexes_in_buckets by going through the whole m_buckets_data instead of finding back the bucket through m_values #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a instead of finding back the bucket through m_values shift_indexes_in_buckets was trying to find back a bucket through m_values but as it modifies the indexes during the iteration, there's a risk of having two buckets with the same index for which we can't reliably know which one still need a shift by delta. Fix issue #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix shift_indexes_in_buckets by going through the whole m_buckets_data instead of finding back the bucket through m_values
shift_indexes_in_buckets was trying to find back a bucket through m_values but as it modifies the indexes during the iteration, there's a risk of having two buckets with the same index for which we can't reliably know which one still need a shift by delta.
Fix issue #38