docs(text area): update syntax dependencies #5587
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the syntax highlighting dependencies in the TextArea docs, which now installs separate language packages rather than `tree-sitter-languages`.
|
I should have searched "tree-sitter-languages" before diving in. I think the whole Adding support for custom languages section will also need updating. It also looks like support for Java highlighting is also now built-in. |
Link to `tree-sitter-language-pack` in the 'see also' section. This is the unoffical replacement for `tree-sitter-languages`, which is now unmaintained and incompatible with the latest tree-sitter.
The 'Adding support for custom languages' section for TextArea syntax highlighting needs updating, since `tree-sitter-languages` is no longer compatible with the latest tree-sitter used in Textual.
My original update using C++ for the custom language example was unfortunately a poor choice, as most highlights are missing!
Remove the unused highlight query file. This was probably once required to screenshot the custom language example in the TextArea docs, but this widget and its docs have since been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the syntax highlighting dependencies in the TextArea docs, which now installs separate language packages rather than
tree-sitter-languages.Please review the following checklist.