Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(text area): update syntax dependencies #5587

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TomJGooding
Copy link
Contributor

Update the syntax highlighting dependencies in the TextArea docs, which now installs separate language packages rather than tree-sitter-languages.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

Update the syntax highlighting dependencies in the TextArea docs, which
now installs separate language packages rather than
`tree-sitter-languages`.
@TomJGooding TomJGooding marked this pull request as draft February 27, 2025 10:21
@TomJGooding
Copy link
Contributor Author

TomJGooding commented Feb 27, 2025

I should have searched "tree-sitter-languages" before diving in. I think the whole Adding support for custom languages section will also need updating. It also looks like support for Java highlighting is also now built-in.

Link to `tree-sitter-language-pack` in the 'see also' section. This is
the unoffical replacement for `tree-sitter-languages`, which is
now unmaintained and incompatible with the latest tree-sitter.
The 'Adding support for custom languages' section for TextArea syntax
highlighting needs updating, since `tree-sitter-languages` is no longer
compatible with the latest tree-sitter used in Textual.
My original update using C++ for the custom language example was
unfortunately a poor choice, as most highlights are missing!
Remove the unused highlight query file. This was probably once required
to screenshot the custom language example in the TextArea docs, but this
widget and its docs have since been updated.
@TomJGooding TomJGooding marked this pull request as ready for review February 27, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant