Skip to content

Tickets System 2 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from Apr 28, 2021
Merged

Tickets System 2 #18

merged 4 commits into from Apr 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 22, 2021

Description

I've added tickets to the main bot, this is okay for now if you want I'll figure out how to get a transcript of chat in a txt file.
I swear this is the last PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (Please specify):

Has this been tested:

  • Yes
  • No
  • Not needed

Checklist:

If any are false, you may still submit, but may be asked to make changes.

  • My code follows the style guidelines of this project

  • [] I have changed/added the help doc at the beginning of any commands changed/added.

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • My changed files do not include any files regularly changed in saves (something where my bot would interfere with this).

  • My changes generate no new warnings

  • I have tested and concluded that my changes are effective or that my feature works - If you have not tested, dont check this so I know to review it more. You may still make a PR for untested code.

  • My code does not cause issues with existing code

  • [] Any dependent changes have been merged and published in downstream modules

  • Some of these options did not apply to my change (Please specify which):

@ghost
Copy link
Author

ghost commented Apr 27, 2021

So @BobDotCom are you going to take the pull request or will this just remain as a folder on my PC :(
Please either close it or take it, please get back ASAP. I'm ready to add transcripts of chat, or any other bug fixes / features.

Also I haven't coded dpy in like 2 weeks so I might be rusty.

@BobDotCom BobDotCom self-requested a review April 28, 2021 20:40
Copy link
Member

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does show some potential so I will merge it into the tickets branch, but it lacks some of the features that we currently have on the tickets bot, such as ticket logging and such. I can work on this when I have time, or @NightZan999 can if you want (of course anyone else would be welcome to contribute as well).

@BobDotCom BobDotCom merged commit 3223586 into The-Coding-Realm:tickets Apr 28, 2021
@ghost
Copy link
Author

ghost commented May 5, 2021

This does show some potential so I will merge it into the tickets branch, but it lacks some of the features that we currently have on the tickets bot, such as ticket logging and such. I can work on this when I have time, or @NightZan999 can if you want (of course anyone else would be welcome to contribute as well).

I have ticket logging, but not the content (see code), but of course the content of the ticket for higher mods to review their moderator's support team for staff checks and promotes / demotes is understandable.

Would you prefer a txt file the same way that Tickets does it?

@BobDotCom
Copy link
Member

txt would work, make sure to log who sent messages and such, and use channel.history so you can log all of the messages, even if the bot goes offline during the middle of the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants