Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #275 #276

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+93 −22
Open

Fix #275 #276

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edc28c0
🧪 Add a test to show #275
Mar 23, 2022
3ed2575
🐛 Fix #275
Mar 23, 2022
f8f852e
🚧 Try to fix other pubsub test broken with previous fix
Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
🚧 Try to fix other pubsub test broken with previous fix 
Signed-off-by: Paul MARS <paul.mars@intrinsec.com>
Paul MARS committed Mar 23, 2022

Unverified

No user is associated with the committer email.
Learn about vigilant mode
commit f8f852ee5622fc610bfcaa90fe4dfb48f921f696
12 changes: 6 additions & 6 deletions pubsub/tests/test_pubsub.go
View file
Original file line number Diff line number Diff line change
@@ -477,12 +477,12 @@ func TestResendOnError(
var publishedMessages message.Messages
allMessagesSent := make(chan struct{})

publishedMessages = PublishSimpleMessages(t, messagesToSend, pub, topicName)
close(allMessagesSent)

messages, err := sub.Subscribe(context.Background(), topicName)
require.NoError(t, err)

publishedMessages = PublishSimpleMessages(t, messagesToSend, pub, topicName)
close(allMessagesSent)

NackLoop:
for i := 0; i < nacksCount; i++ {
select {
@@ -524,6 +524,9 @@ func TestNoAck(
require.NoError(t, subscribeInitializer.SubscribeInitialize(topicName))
}

messages, err := sub.Subscribe(context.Background(), topicName)
require.NoError(t, err)

for i := 0; i < 2; i++ {
id := watermill.NewUUID()
log.Printf("sending %s", id)
@@ -534,9 +537,6 @@ func TestNoAck(
require.NoError(t, err)
}

messages, err := sub.Subscribe(context.Background(), topicName)
require.NoError(t, err)

receivedMessage := make(chan struct{})
unlockAck := make(chan struct{}, 1)
go func() {