Improve index.d.ts by adding the constructor options type #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguijarr
approved these changes
Jul 21, 2022
cmarindev
approved these changes
Jul 21, 2022
TimonKK
reviewed
Aug 15, 2022
| @@ -1,24 +1,1639 @@ | |||
| { | |||
| "name": "clickhouse", | |||
| "version": "2.5.0", | |||
| "lockfileVersion": 1, | |||
| "lockfileVersion": 2, | |||
There was a problem hiding this comment.
What is point for package version changes?
There was a problem hiding this comment.
Hi TimonKK,
The npm version that I've installed (8) is causing the change.
No problems are expected because the lockfileVersion 2 is backwards compatible with version 1.
https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json#lockfileversion
Thanks in advance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the typescript support by adding the constructor options type.
The new type is
ClickHouseOptionsand its properties have been inferred manually.