-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes CB-7781 #62
base: master
Are you sure you want to change the base?
Fixes CB-7781 #62
Conversation
With this change the issue reported in https://issues.apache.org/jira/browse/CB-7781. Tested and working perfectly now while uninstalling plugin
Is this going to be merged in? |
why do the tests fail with this patch? |
Needs a regression test. |
waiting forward for this, |
FWIW I manually applied this patch and it allowed me to remove a plugin in Ionic/Cordova. |
same here |
I'm glad that manually applying the patch fixes your problem, but it would be nice if this pull request had at least one test demonstrating the fix. Submitting patches without tests isn't acceptable. |
@mreinstein Here you go, for
|
I've finally got the testing infrastructure somewhat working again. If you re-submit a clean PR with tests included we can merge this now. Sorry for the painfully long response time on this. 🤦 |
With this change the issue reported in https://issues.apache.org/jira/browse/CB-7781.
Tested and working perfectly now while uninstalling plugin