Use pkg-config for sqlite3 if available #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
added a commit
that referenced
this pull request
May 31, 2011
Use pkg-config for sqlite3 if available
|
Thanks! |
|
Sorry to bring this back, but previous changeset has problems due to me using the docs for newer waf version, which behaves differently from the one that node uses. Changeset audriusk@a054e157f73f6ae83381b1ce19ab74342dc14942 fixes that (and this time it has been tested properly, promise!). |
|
Can you create a pull request for that please? |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added pkg-config support in wscript for sqlite3, since I wasn't able to build node-sqlite3 otherwise on Slackware Linux 13.37. This also works on Joyent Node SmartMachine after pkg-config is installed using pkgin.