refactor: improve error messages of loadDirectory and refactor #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the biggest change is to use the java.nio.file.Path abstraction (https://docs.oracle.com/javase/8/docs/api/java/nio/file/Path.html) instead of manually manipulating slashes. this should make it more robust on different platforms, and more reasonable in the face of paths which contain semantically equivalent but syntactically different paths (e.g., multiple slashes in a row `//` or `.` path components). it also improves readability by using methods with path-specific names instead of manipulating lists and strings. some other changes to add more comments and use more functional programming.
ailrst
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the biggest change is to use the java.nio.file.Path abstraction (https://docs.oracle.com/javase/8/docs/api/java/nio/file/Path.html) instead of manually manipulating slashes. this should make it more robust on different platforms, and more reasonable in the face of paths which contain semantically equivalent but syntactically different paths (e.g., multiple slashes in a row
//or.path components).it also improves readability by using methods with path-specific names instead of manipulating lists and strings. some other changes to add more comments and use more functional programming.
in most cases, the new behaviour should be equivalent to the old one. in cases with elements like
//or., the behaviour should be more reasonable - now, it correctly treats those as insignificant.