-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo xarray with MetPy tutorial for 1.0 #1605
Conversation
This pull request introduces 1 alert when merging 4581a27 into f991506 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work. I just found a few minor things here.
This pull request introduces 1 alert when merging 4f5d697 into 495061a - view on LGTM.com new alerts:
|
If you rebase on master, that should clean up Code Climate. |
4f5d697
to
83e5a21
Compare
Remaining comments should now have been addressed, and I've rebased on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can think of a way to make LGTM happy, great. Regardless, I'm happy to merge, though.
20f3a6e
to
d3cfd73
Compare
d3cfd73
to
32e2090
Compare
Description Of Changes
Overhaul the xarray with MetPy tutorial given the substantial changes in xarray support for the 1.0 release. Part of the remaining effort towards #1385. This makes extensive use of HTML reprs for xarray and Pint, so it is nice that we've gotten that working seemingly well with the new theme.
Checklist
ClosesTests added