This repository was archived by the owner on Sep 1, 2022. It is now read-only.
make sure scan_geom and sweep_angle_axis are properly tracked and used #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GEOSTransformclass was refactored in 2014, and while the types of the parameters in the signature of the constructors didn't change, the meaning of some of the parameters in some of the constructors did. Specifically, some constructors started taking the sweep angle axis (xory) instead of the scan geometry (GOESorGEOS).#1198 addressed this in the copy constructor, but that was only a partial fix. This PR makes sure the correct parameter is passed into the
GEOSTransformconstructor, and ensures the scan geometry field insideGOESTransformis correctly set.Special thanks to @phollemans for the pointers and feedback!