This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Add trajectory FT detection to HdfEos, clean up code a bit #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating fork
if either of semi_minor_axis or inv_flattening is present but other is not, then the missing value can be calculated from the other and from semi_manor_axis.
|
|
|
The test suite results look good, so I'll go ahead and merge. Thank you @msdsoftware! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds detection of the trajectory featureType to the HdfEos class discussed in #932.
I also did some code clean-up in that class: wrapping all if blocks in braces, systematic indentation in a couple methods, and converting all System.out.println/printf to log.debug. I left in the showWork boolean on the debugs but it's redundant and could be removed in a future update.